eclipse-jdt / eclipse.jdt.core

Eclipse Public License 2.0
156 stars 123 forks source link

Fixed apt test failing with Java 1.8 compilation settings #2763

Closed iloveeclipse closed 1 month ago

iloveeclipse commented 1 month ago

There are few interesting observations:

1) The test fail didn't show up in jenkins. I can't see why. 2) The test fails now because an unexpected execution from BatchGenProcessor happens, which wasn't there before. 3) The MixedModeTesting.testAPTRoundingInMixedMode1() was added before BatchGenProcessor was added, and never run into the BatchGenProcessor code, it only used BatchGen1AnnotationProcessor. Now both processors are active, resulting in a duplicated output. 4) Both processors are active now because we enable annotation processing by default with 1.8 level projects (and required an explicit option for 1.4).

For now I've simply updated test expectation.

See https://github.com/eclipse-jdt/eclipse.jdt.core/issues/2536