search

eclipse-jdt / eclipse.jdt.core

Eclipse Public License 2.0
157 stars 124 forks source link

[23][IDE Support] JEP 455: Primitive Types in Patterns, instanceof, and switch (Preview) #2298 #2844

Closed mpalat closed 1 week ago

mpalat commented 3 weeks ago

IDE Support

Create issues as required.

stephan-herrmann commented 3 weeks ago

@mpalat any idea of what should be done here? Any new AST nodes?? New references to be considered for search?

Looking from a distance this issues looks like a no-op.

mpalat commented 3 weeks ago

@stephan-herrmann At this point I also believe that its a no-op. Will revisit once we have the complete compiler support up to check for nuances and corner cases.

stephan-herrmann commented 2 weeks ago

@stephan-herrmann At this point I also believe that its a no-op. Will revisit once we have the complete compiler support up to check for nuances and corner cases.

As I just closed #2298 be my guest :)

mpalat commented 1 week ago

IDE Support

  • DOM AST + Rewrite
  • Search
  • Selection
  • Content Assist
  • Formatter

Create issues as required.

I don't see anything that needs to be done for DOM AST/Rewrite, Search, Selection or Formatter. Perhaps we can enhance content assist with the primitives also being listed as options - created https://github.com/eclipse-jdt/eclipse.jdt.core/issues/2886 - not a blocker requirement.

mpalat commented 1 week ago

no blocker issue for this milestone - Content assistant issue #2886 may be taken up later if need be.. closing.