search

eclipse-jdt / eclipse.jdt.core

Eclipse Public License 2.0
164 stars 130 forks source link

[23][IDE Support] JEP 477: Implicitly Declared Classes and Instance Main Methods (Third Preview) #2474 #2847

Closed mpalat closed 1 month ago

mpalat commented 2 months ago

IDE Support for issue #2474

DOM AST + Rewrite Search Selection Content Assist Formatter Create issues as required.

mpalat commented 2 months ago

@jarthana can you please take a look whether something is needed here? I am wondering what will be shown in AST View [AST DOM usage] for example? And for a search for the implicit class? Type hierarchy etc..

jarthana commented 2 months ago

Other than search, of which I don't have much idea, I don't think we need anything here. I can see DOM nodes being added and functioning as expected and code assist in general working. I think some of the list is irrelevant, like the type hierarchy.

I tried some basic things with search that appear to be working. But as an expert in this area, I will let you decide whether something else is required here.

stephan-herrmann commented 2 months ago

Other than search

I don't think that implicit classes are really relevant for search, as no-one outside can see them, right?

Has anyone tried to format an implicit class?

mpalat commented 1 month ago

Other than search

I don't think that implicit classes are really relevant for search, as no-one outside can see them, right?

right, search not relevant here. @subyssurendran666 is adding search testcases via issue #2907

Has anyone tried to format an implicit class?

Formatter support will be tracked via issue #2977

am closing this issue - individual issues will track the above items.