search

eclipse-jdt / eclipse.jdt.core

Eclipse Public License 2.0
157 stars 124 forks source link

[tests] organize imports #2579 #2871

Open jukzi opened 2 weeks ago

jukzi commented 2 weeks ago

https://github.com/eclipse-jdt/eclipse.jdt.core/issues/2579

jukzi commented 2 weeks ago

@stephan-herrmann when is a good timepoint to submit this? Its purely the automatic cleanup (takes ~1min). As a second step we could then change the options. If beta branch is different it is possibly simpler to do the same refactoring there instead of solving merge conflicts if any.

stephan-herrmann commented 2 weeks ago

@stephan-herrmann when is a good timepoint to submit this? Its purely the automatic cleanup (takes ~1min). As a second step we could then change the options.

We should not leave much time between automatic cleanup and changing the options to avoid fresh drift between both actions. My preference: two commits (not-squashed) within one PR.

If beta branch is different it is possibly simpler to do the same refactoring there instead of solving merge conflicts if any.

Generally I'd do such things only when there's only one writable branch. This will be guaranteed once the beta branch has been merged to master (around 17 September)

Alternatively, doing this in the beta branch is an interesting idea, but that would conflict with any other changes between Simrel GA and JDK 23 GA. We don't want to close master until the latter.

Also, the beta branch is under some stress until release, so probably better not to stir up unnecessary dust there right now.

So if you could hold your horses just 3 more weeks that would be safest :)

stephan-herrmann commented 2 weeks ago

On the positive side #2679 should help avoid that import changes result in warning changes :)