[23] Folding a markdown region hides the first line of subsequent Java

eclipse-jdt / eclipse.jdt.core

Eclipse Public License 2.0

164 stars 130 forks source link

[23] Folding a markdown region hides the first line of subsequent Java #2943

Open jarthana opened 1 month ago

jarthana commented 1 month ago

code

What it does

Fixes https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/1615

How to test

Author checklist

[ ] I have thoroughly tested my changes
[ ] The change is following the coding conventions
[ ] I have signed the Eclipse Contributor Agreement (ECA)

jarthana commented 1 month ago

This fix introduces a problem in a corner case when the markdown ends with a param or other incomplete tag and no whitespace before the closing \n, which is not part of the markdown doc. I have adjusted a testcase to pass, but will take that up via a different issue.

jarthana commented 1 month ago

OK, this is stuck with a hung test case. I don't think this is going in for the GA release. Will take it up post-merge.