search

eclipse-jdt / eclipse.jdt.core

Eclipse Public License 2.0
168 stars 133 forks source link

[Modernization][4.35+] What would it take to make TerminalTokens an enumeration ? #3303

Open srikanth-sankaran opened 2 weeks ago

srikanth-sankaran commented 2 weeks ago

It would make debugging the parser and scanner SO MUCH easier. What are the complications if any ??

iloveeclipse commented 2 weeks ago

I have no IDE at hand, but I believe there was some code that copied or translated these constants in some "upper" JDT layer constants, see https://github.com/eclipse-jdt/eclipse.jdt.core/pull/10. If that also wkrks with enums, why not.

iloveeclipse commented 2 weeks ago

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=576117 for background.