Closed iloveeclipse closed 2 years ago
@iloveeclipse have you seen that this issue has a long history?
After your change, is the original check still performed (didn't check the code)?
@stephan-herrmann : sure, the change only prevents the problem to show 1000 times. Thanks for pointers, I was not aware the issue is old one, haven't seen such high number of fails yet.
~1100 formatter tests failed with exact same problem on Windows/Java 11 build only:
org.eclipse.jdt.core.tests.formatter.FormatterCommentsBugsTest.testBug121728
Failure seem to be a problem with restoring workspace preferences after the test. I don't think it is Windows related, it looks like some random error.
Note: the code checks that
JavaCore.getOptions()
equals to expected defaults fromorg.eclipse.jdt.core.JavaCore.getDefaultOptions()
.I see no immediate reason why this particular test would mess up options, nor recent related changes.
However I also do not see any code that would "fix" broken options to defaults. I will add a change so that options are properly reset to avoid following tests might be affected by some previous failure.