search

eclipse-jdt / eclipse.jdt.debug

Eclipse Public License 2.0
16 stars 46 forks source link

Remove blank Javadoc #344

Closed jukzi closed 9 months ago

jukzi commented 10 months ago

This commit cleans up Javadoc that does not add information. It resolves ecj warnings: Javadoc: Description expected after ... It helps to prevent future empty javadoc by disabling missingJavaDoc warnings. This resolves Javadoc: Missing ...

The modification is a result of regular expression search&replace:

in files *.java ^[\s]*\*[\s]*(@return|@param[\s]*[^\s]+|@throws[\s]*[^\s]+)\R([\s]*\*[\s]*@|[\s]*\*/\R) ->$2 ^([\s]*\*[\s]*\R)([\s]*\*/\R) ->$2 ^[\S\t]*/\*\*\R[\s]*\*/\R ->``

in files org.eclipse.jdt.core.prefs org\.eclipse\.jdt\.core\.compiler\.problem\.missingJavadoc(Comments|Tags)\=[^\s]* ->org\.eclipse\.jdt\.core\.compiler\.problem\.missingJavadoc$1\=ignore

iloveeclipse commented 10 months ago

Be careful, some test resources are line dependent because the tests create line breakpoints.

jukzi commented 10 months ago

Be careful, some test resources are line dependent because the tests create line breakpoints.

totally agreed. i tried to filter resources away. if i missed some i will remove those from commit

jukzi commented 9 months ago

@laeubi tycho still does not build output.jdimodel.jar = bin/

09:37:20  [ERROR] Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.4:verify (verify) on project org.eclipse.jdt.debug: There are API errors:
09:37:20  [ERROR] jdi/org/eclipse/jdi/Bootstrap.java:19 The type org.eclipse.jdi.Bootstrap has been removed from org.eclipse.jdt.debug_3.21.300
akurtakov commented 9 months ago

@laeubi is https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/pull/1530 supposed to help here ?

laeubi commented 9 months ago

@akurtakov yes see

https://github.com/eclipse-tycho/tycho/blob/c918e72c441d557fc82b6f691ddedc48ff3739ce/tycho-its/src/test/java/org/eclipse/tycho/test/apitools/ApiToolsTest.java#L128-L144 https://github.com/eclipse-tycho/tycho/tree/master/tycho-its/projects/api-tools/single-jar

it is added as a (verified) test case there (Tycho 4.0.5 +).

@jukzi build still uses "old" Tycho 4.0.4 as there is no new release yet.

jukzi commented 9 months ago

@jukzi build still uses "old" Tycho 4.0.4 as there is no new release yet.

When will the build use a working Tycho version? Is there a workaround?

akurtakov commented 9 months ago

Manual rebase needed.