search

eclipse-jdt / eclipse.jdt.debug

Eclipse Public License 2.0
16 stars 46 forks source link

JavaSnippetEditor: fix `getShell() was called after part disposal` #357

Closed jukzi closed 9 months ago

jukzi commented 9 months ago

from https://ci.eclipse.org/jdt/job/eclipse.jdt.debug-github/job/PR-355/4/consoleText

[2023-12-04T10:24:52.387Z] !MESSAGE [testEvaluation] setUp
[2023-12-04T10:24:55.669Z] 
[2023-12-04T10:24:55.669Z] !ENTRY org.eclipse.ui.workbench 4 0 2023-12-04 10:24:55.597
[2023-12-04T10:24:55.669Z] !MESSAGE IWorkbenchSite.getShell() was called after part disposal: PartSite(id=org.eclipse.jdt.debug.ui.SnippetEditor,pluginId=org.eclipse.jdt.debug.ui,registeredName=Scrapbook,hashCode=65244196)
[2023-12-04T10:24:55.669Z] !STACK 0
[2023-12-04T10:24:55.669Z] java.lang.IllegalStateException: IWorkbenchSite.getShell() was called after part disposal: PartSite(id=org.eclipse.jdt.debug.ui.SnippetEditor,pluginId=org.eclipse.jdt.debug.ui,registeredName=Scrapbook,hashCode=65244196)
[2023-12-04T10:24:55.669Z]  at org.eclipse.ui.internal.PartSite.getShell(PartSite.java:451)
[2023-12-04T10:24:55.670Z]  at org.eclipse.jdt.internal.debug.ui.snippeteditor.JavaSnippetEditor.getShell(JavaSnippetEditor.java:1084)
[2023-12-04T10:24:55.670Z]  at org.eclipse.jdt.internal.debug.ui.snippeteditor.JavaSnippetEditor$3.run(JavaSnippetEditor.java:639)
[2023-12-04T10:24:55.670Z]  at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:40)
[2023-12-04T10:24:55.670Z]  at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:132)
[2023-12-04T10:24:55.670Z]  at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:5038)
[2023-12-04T10:24:55.670Z]  at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4518)
[2023-12-04T10:24:55.670Z]  at org.eclipse.jdt.debug.tests.DebugSuite.run(DebugSuite.java:77)
[2023-12-04T10:24:55.670Z]  at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:90)
[2023-12-04T10:24:55.670Z]  at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:316)
[2023-12-04T10:24:55.670Z]  at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:240)
[2023-12-04T10:24:55.670Z]  at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:214)
[2023-12-04T10:24:55.670Z]  at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:155)
[2023-12-04T10:24:55.670Z]  at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
[2023-12-04T10:24:55.670Z]  at java.base/java.lang.reflect.Method.invoke(Method.java:580)
[2023-12-04T10:24:55.670Z]  at org.apache.maven.surefire.api.util.ReflectionUtils.invokeMethodWithArray2(ReflectionUtils.java:137)
[2023-12-04T10:24:55.670Z]  at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:148)
[2023-12-04T10:24:55.670Z]  at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:88)
[2023-12-04T10:24:55.670Z]  at org.eclipse.tycho.surefire.osgibooter.OsgiSurefireBooter.run(OsgiSurefireBooter.java:140)
[2023-12-04T10:24:55.670Z]  at org.eclipse.tycho.surefire.osgibooter.AbstractUITestApplication$1.run(AbstractUITestApplication.java:42)
[2023-12-04T10:24:55.670Z]  at org.eclipse.e4.ui.internal.workbench.swt.E4Testable.lambda$1(E4Testable.java:127)
[2023-12-04T10:24:55.670Z]  at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:40)
[2023-12-04T10:24:55.670Z]  at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:132)
[2023-12-04T10:24:55.670Z]  at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:5038)
[2023-12-04T10:24:55.670Z]  at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4518)
[2023-12-04T10:24:55.670Z]  at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1152)
[2023-12-04T10:24:55.670Z]  at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
[2023-12-04T10:24:55.670Z]  at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1043)
[2023-12-04T10:24:55.670Z]  at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:152)
[2023-12-04T10:24:55.670Z]  at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:648)
[2023-12-04T10:24:55.670Z]  at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
[2023-12-04T10:24:55.670Z]  at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:555)
[2023-12-04T10:24:55.670Z]  at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:173)
[2023-12-04T10:24:55.670Z]  at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:152)
[2023-12-04T10:24:55.670Z]  at org.eclipse.tycho.surefire.osgibooter.UITestApplication.runApplication(UITestApplication.java:34)
[2023-12-04T10:24:55.670Z]  at org.eclipse.tycho.surefire.osgibooter.AbstractUITestApplication.run(AbstractUITestApplication.java:129)
[2023-12-04T10:24:55.670Z]  at org.eclipse.tycho.surefire.osgibooter.UITestApplication.start(UITestApplication.java:44)
[2023-12-04T10:24:55.670Z]  at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:208)
[2023-12-04T10:24:55.670Z]  at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:136)
[2023-12-04T10:24:55.670Z]  at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
[2023-12-04T10:24:55.670Z]  at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:402)
[2023-12-04T10:24:55.670Z]  at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:255)
[2023-12-04T10:24:55.670Z]  at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
[2023-12-04T10:24:55.670Z]  at java.base/java.lang.reflect.Method.invoke(Method.java:580)
[2023-12-04T10:24:55.670Z]  at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:651)
[2023-12-04T10:24:55.670Z]  at org.eclipse.equinox.launcher.Main.basicRun(Main.java:588)
[2023-12-04T10:24:55.670Z]  at org.eclipse.equinox.launcher.Main.run(Main.java:1459)
[2023-12-04T10:24:55.670Z]  at org.eclipse.equinox.launcher.Main.main(Main.java:1432)
jukzi commented 9 months ago

the exception is not shown in https://ci.eclipse.org/jdt/job/eclipse.jdt.debug-github/job/PR-357/2/consoleText