Open Bananeweizen opened 8 months ago
I tested the PR and it works.
Manually i found also JDKs installed in
C:\Program Files\Eclipse Foundation\jdk-11.0.12.7-hotspot
C:\Program Files\Java\jdk1.8.0_202
which have not been found. i don't know if that are standard paths some how, but i can not remember to have selected them manually.
I would be good to search also in the system "PATH"s, where the commandline would also find the "java" command.
It might be nice to have an information logged like
ILog.get().info("Detected installed JVM: " + name); //$NON-NLS-1$
What do you think?
@merks how does OOmph detect JVMs?
We do similar adhoc things:
Also some native stuff to look in the system registry:
I think there are other more modern ways in which one could look in the system registry. Even here you know to know for which keys to search.
Oomph as an advantage that it stores information globally for reuse across installations and workspaces...
@Bananeweizen
oracles JDK installs to programm files\java\ by default
please add that and then this PR is good to go.
What it does
The JDK detection mechanism doesn't find much on Windows. Have it find the default installation directories of Adoptium and RedHat, both in the 64 and 32 bit installation directories. Further JDK distributors can easily be added without changing the code logic.
Also let duplicate VM names start with index 2, not 1. And finally improve the job name.
On my machine that change adds the upper 4 entries of this screenshot:![grafik](https://github.com/eclipse-jdt/eclipse.jdt.debug/assets/406876/1dc86711-5d98-41e0-a546-70013251b1fb)
How to test
Install Adoptium or Redhat OpenJDK in default location and check preference page.
Author checklist