search

eclipse-jdt / eclipse.jdt.debug

Eclipse Public License 2.0
16 stars 46 forks source link

don't fail build on test error #383

Closed jukzi closed 6 months ago

jukzi commented 6 months ago

@iloveeclipse @akurtakov with this change failed tests or quality gate image don't show as FAILED (red) but UNSTABLE (orange) on Jenkins image

, nevertheless on Github the Checks are shown as RED. Before tests eager failed the build skipping warning analysis.

Also i enable javadoc analysis - before javadoc plugin did not detect warnings because it was not enabled. With this changes only new warnings - related to the changes in the PR - should fail PRs. Currently the PR contains an intentional a bug to show the behavior.

would copy&paste this solution on all JDT repos. WDYT?

iloveeclipse commented 6 months ago

Could it be, that if we don't have any warnings and only a test fail, github will show everything green? Is therea way to test that and see how it looks like?

jukzi commented 6 months ago

i have no fast idea how to test that, but obviously this check refers to the failed test: image

jukzi commented 6 months ago

i have created a PR that should not show any warning: https://github.com/eclipse-jdt/eclipse.jdt.debug/pull/386 (by removing all Warning Plugins)

jukzi commented 6 months ago

486 finished unstable on jenkins and red on github. i think that proofs the concept.

iloveeclipse commented 6 months ago

486 finished unstable on jenkins and red on github. i think that proofs the concept.

OK, thanks. I have no concerns in that case.