Closed jukzi closed 6 months ago
Could it be, that if we don't have any warnings and only a test fail, github will show everything green? Is therea way to test that and see how it looks like?
i have no fast idea how to test that, but obviously this check refers to the failed test:
i have created a PR that should not show any warning: https://github.com/eclipse-jdt/eclipse.jdt.debug/pull/386 (by removing all Warning Plugins)
486 finished unstable on jenkins and red on github. i think that proofs the concept.
486 finished unstable on jenkins and red on github. i think that proofs the concept.
OK, thanks. I have no concerns in that case.
@iloveeclipse @akurtakov with this change failed tests or quality gate
don't show as FAILED (red) but UNSTABLE (orange) on Jenkins
![image](https://github.com/eclipse-jdt/eclipse.jdt.debug/assets/51790620/8120e8af-2d70-40b0-9c48-ad7491d0696d)
, nevertheless on Github the Checks are shown as RED. Before tests eager failed the build skipping warning analysis.
Also i enable javadoc analysis - before javadoc plugin did not detect warnings because it was not enabled. With this changes only new warnings - related to the changes in the PR - should fail PRs. Currently the PR contains an intentional a bug to show the behavior.
would copy&paste this solution on all JDT repos. WDYT?