Fix concat to MessageFormat and String.format - Githubissues

eclipse-jdt / eclipse.jdt.ui

Eclipse Public License 2.0

35 stars 86 forks source link

Fix concat to MessageFormat and String.format #1423

Closed jjohnstn closed 2 months ago

jjohnstn commented 3 months ago

fix ConvertToMessageFormatFixCore and ConvertToStringFormatFixCore to refine the logic for determining when to use a text block vs a single line - logic now only uses text block if there are 3 or more lines used in the concatenation AND the number of string literal characters is greater than 80
modify existing tests and add new tests to AssistQuickFixTest15
fixes #1406

What it does

See commit message.

How to test

See issue or new tests.

Author checklist

[x] I have thoroughly tested my changes
[x] The change is following the coding conventions
[x] I have signed the Eclipse Contributor Agreement (ECA)