eclipse-jdt / eclipse.jdt.ui

Eclipse Public License 2.0
32 stars 79 forks source link

Fix buggy Javadoc styling enhancements menu +hard to read colored type parameters (#1442) #1482

Closed RedeemerSK closed 1 week ago

RedeemerSK commented 2 weeks ago

What it does

Fixes buggy styling enhancements menu (see https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/1442#issuecomment-2154709945):

Also makes Javadoc to render (generic) type parameters with same font-weight (was lighter) like the rest of the method signature - see https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/1442#issuecomment-2155658440

How to test

Toggle / change all styling enhancements settings via styling enhancements menu on JavadocHover's and JavadocView's tollbar and confirm styling enhancements menu reflect current settings + javadoc content being displayed and available actions have expected results (eg. toggling / changing / resetting colors). Scenarios of using styling enhancements menu to consider:

Author checklist

iloveeclipse commented 1 week ago

I've just rebased on master to run tests / checks on latest head before merge. The patch looks good for me, many thanks! Here screenshot: image