Fix calculation if cast needed for simplifying lambda to method ref - Githubissues

eclipse-jdt / eclipse.jdt.ui

Eclipse Public License 2.0

36 stars 86 forks source link

Fix calculation if cast needed for simplifying lambda to method ref #1504

Closed jjohnstn closed 2 months ago

jjohnstn commented 2 months ago

change castMethodRefIfNeeded() methods in LambdaExpressionAndMethodRefFixCore and ConvertLambdaToMethodReferenceFixCore to handle parameterized types better
add new tests to CleanUpTests1d8 and AssistQuickFixTest1d8
fixes #1498

What it does

Fixes lambda to method ref cleanup/quick assists to not add extraneous cast.

How to test

See issue or new tests.

Author checklist

[x] I have thoroughly tested my changes
[x] The change is following the coding conventions
[x] I have signed the Eclipse Contributor Agreement (ECA)

HannesWell commented 2 months ago

Thanks a lot for the fast fix. :)