Fix addStaticImportFavoriteProposals for generic types

[estepper]

When you add a static method to a generic type and add it to the list of content assist favorites you can't use Quick Fix to add the required static import.

Let's say you have a helper class as follows:

package content_assist_test;

public class EikesHelper<T>
{
   public static void help()
   {
   }
}

Then you configure that static method as a content assist favorite: content_assist_test.EikesHelper.test

Then you write a class to test it:

public class EikesTest
{
   public static void test()
   {
      help();
   }
}

The call to the help() method is marked as a compiler error. When you open the Quick Fix menu it looks as follows:

When you execute the Quick Fix a wrong import statement is inserted.

The problem is caused by a small bug in org.eclipse.jdt.internal.ui.text.correction.UnresolvedElementsBaseSubProcessor.addStaticImportFavoriteProposals(). In line 1497 it computes the qualifiedTypeName from the fully qualified method name curr. As curr contains the string "<T>", the Signature.getQualifier() method behaves wrongly and cuts off too much.

My fix is to strip off the generic part of the type name with the help of Signature.getTypeErasure() before Signature.getQualifier() is called. The result looks like so, now:

[jjohnstn]

Thanks @estepper

[estepper]

Thanks for the prompt reaction!