eclipse-jdt / eclipse.jdt.ui

Eclipse Public License 2.0
36 stars 86 forks source link

Removing unnecessary themeing extension for breadcrumb (light theme) #1577

Open mvm-sap opened 1 month ago

mvm-sap commented 1 month ago

What it does

We have improved the look and feel of existing light theme in eclipse. Please refer this https://github.com/eclipse-platform/eclipse.platform.ui/issues/2114 for further information on the same. There was a bug reported as part of this theme change, which could be found here https://github.com/eclipse-platform/eclipse.platform.ui/issues/2114#issuecomment-2241561690. While fixing this issue we figured out that the grey background for breadcrumb is unnecessary and hence removed the light theme extension. Please find below the screenshot of how it looks with and without extension both in old and new light themes image image image

How to test

Enable breadcrumb and test the changes with old and enhanced light theme.

Author checklist

BeckerWdf commented 1 month ago

@vogella: Aren't you a JDT comitter. Can you review and if ok merge this PR?

vogella commented 1 month ago

@BeckerWdf No I'm not a JDT committer, maybe @jjohnstn can review?