search

eclipse-jdt / eclipse.jdt.ui

Eclipse Public License 2.0
37 stars 90 forks source link

[23] Compiler compliance level 23 missing (BETA) label #1588

Closed noopur2507 closed 1 month ago

noopur2507 commented 2 months ago

In compiler preferences, compliance level 23 is not having the label (BETA) in the latest Y-build.

This was added initially via https://github.com/eclipse-jdt/eclipse.jdt.ui/pull/1350/files#diff-75bddcdfd2484e74dd12777aa5f88c804a476cb214989f7363c5a654ef9eb0b1.

It seems to have been removed while dropping the support for older Java versions.

noopur2507 commented 2 months ago

/cc @iloveeclipse

iloveeclipse commented 2 months ago

I'm on vacation till 27 August without access to computer. I guess the merge from master to BETA branch was not OK.

stephan-herrmann commented 2 months ago

I'm on vacation till 27 August without access to computer. I guess the merge from master to BETA branch was not OK.

The merge was OK, just the new strategy without separately defined labels cannot handle this requirement.

We could manually replace "23" with "23 (BETA)" inside ComplianceConfigurationBlock.createComplianceTabContent(Composite) but that would add yet another task to the preparations for GA, when such disclaimers are to be removed.

Does JDT/UI have a central location where "beta-ness" is handled?

noopur2507 commented 2 months ago

Does JDT/UI have a central location where "beta-ness" is handled?

No. Another place where early-draft disclaimer is added is ComplianceConfigurationBlock.validateComplianceStatus().

stephan-herrmann commented 2 months ago

Does JDT/UI have a central location where "beta-ness" is handled?

No. Another place where early-draft disclaimer is added is ComplianceConfigurationBlock.validateComplianceStatus().

Thanks, In #1621 I tried to add the "(BETA)" suffix in a way that doesn't cause more maintenance efforts. I admit that the manual label manipulation is not the most elegant code.

@noopur2507 what do you think?

stephan-herrmann commented 1 month ago

Fixed for now by https://github.com/eclipse-jdt/eclipse.jdt.ui/pull/1621