Prevent potential `ClassCastException` in 'add service provider' quickfix

datho7561 commented 3 weeks ago

Fixes #1598

What it does

Switch && to || to prevent a ClassCastException in the case that the parent node is not a ProvidesDirective.

How to test

Set a debug point before the line that was changed, and modify the AST so that the parent node is not a ProvidesDirective. The method should return on the line after the line that was changed.

I don't have a method to reproduce this without modifying variables in memory, since the bug relies on a faulty error range or AST being generated by the compiler.

Author checklist

[x] I have thoroughly tested my changes
[x] The change is following the coding conventions
[x] I have signed the Eclipse Contributor Agreement (ECA)

jjohnstn commented 3 weeks ago

This will have to wait until 4.34 M1 is open as it is not critical for RC2.

datho7561 commented 1 week ago

@jjohnstn if you have some time, could you please take a look at this?

jjohnstn commented 1 week ago

@datho7561 Will do so today

eclipse-jdt / eclipse.jdt.ui