eclipse-jdt / eclipse.jdt.ui

Eclipse Public License 2.0
36 stars 86 forks source link

[23] Highlight 'module' in module imports #1605

Closed stephan-herrmann closed 2 weeks ago

stephan-herrmann commented 3 weeks ago

Add semantic highlighting for 'module' in an module import declaration (as "Restricted Identifier").

fixes https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/1589

stephan-herrmann commented 3 weeks ago
22:41:19  [ERROR] /home/jenkins/agent/workspace/eclipse.jdt.ui-github_PR-1605/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/SemanticHighlightingReconciler.java:[226] 
22:41:19  [ERROR]   if (keyword == ModifierKeyword.MODULE_KEYWORD) {
22:41:19  [ERROR]                                  ^^^^^^^^^^^^^^
22:41:19  [ERROR] MODULE_KEYWORD cannot be resolved or is not a field

This signals that https://github.com/eclipse-jdt/eclipse.jdt.core/issues/2834 is not yet available from a Y-build.