Use mockito-core instead of mockito-all

eclipse-jdtls / eclipse.jdt.ls

Java language server

1.74k stars 387 forks source link

Use mockito-core instead of mockito-all #1087

Open gatesn opened 5 years ago

gatesn commented 5 years ago

mockito-all brings in some Hamcrest classes which conflict with hamcrest 1.3.0 also on the test classpath.

fbricon commented 5 years ago

IIRC we depend on a version of Mockito that's compatible with OSGi classloaders. @gatesn if you can provide a PR that passes all tests, then we should be fine

gatesn commented 5 years ago

I’m not too familiar with OSGi, but it seems like only Mockito-all is available as a “bundle”.