search

eclipse-jdtls / eclipse.jdt.ls

Java language server
1.8k stars 400 forks source link

Remove support for named pipes #455

Closed fbricon closed 6 years ago

fbricon commented 6 years ago

Currently named pipe support is provided via a 3rd party library, https://github.com/kohlschutter/junixsocket, which has not been updated in over 3years. Forks exist (https://github.com/fiken/junixsocket seems the most active) so we could maybe depend on that instead.

32bit platforms are not supported by the junixsocket library and there are already 2 other connection alternatives (stdio and sockets) which work for all platforms, so, unless there's a really compelling reason to keep it, I think we could drop named pipes support.

If you're a 3rd party adopter depending on this feature, is migrating to another connection mechanism an option? Please vote for this issue and let's know which direction we should take wrt named pipe support.

snjeza commented 6 years ago

+1

othomann commented 6 years ago

+1

gorkem commented 6 years ago

Should we print a deprecation notice for a few releases and then remove?

fbricon commented 6 years ago

@gorkem definitely, that's what I had in mind. Kill it after a couple releases of deprecation to give some room for adopters to adapt, if necessary.

fbricon commented 6 years ago

Ok so we'll start deprecating named pipes support in 0.10.0 (mid December 2017), for a full removal in 0.12.0 (end January 2018)