Open TheSnoozer opened 8 months ago
I found more context on this.
Jgit's constants are defined here:
This 0x47444132 seems to come from https://github.com/git/git/blob/a26002b62827b89a19b1084bd75d9371d565d03c/commit-graph.c#L48-L49 and is simply not listed as magic value in jgit.
It was introduced with this change: https://github.com/git/git/commit/6dbf4b8172ef9edd50bdf9ca2da4681ba9153f75
I found the relevant references on this discussion
there is a stale change 203182 in review adding support for writing generation numbers
That chunk is for GDA2 (generation numbers v2). JGit doesn't support that yet. When the parser finds an unknown chunk, it just logs it and ignores that chunk.
If this bug is about the warning log, we can close it as "working as intended". The actual feature request is "support generation number v2" in jgit.
Version
6.7.0.202309050840-r
Operating System
MacOS
Bug description
When running the git-commit-id-maven-plugin (which uses jgit under the hood) a warning about unknown commit-graph chunk is reported.
This warning seems to only be reproducible under mac using a
The message templates are defined in:
org.eclipse.jgit/resources/org/eclipse/jgit/internal/JGitText.properties:commitGraphChunkUnknown=unknown commit-graph chunk: 0x{0}
and the error observed comes from: https://github.com/eclipse-jgit/jgit/blob/b1cc74b75b771279d81de15833da514c71513648/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/CommitGraphLoader.java#L194-L196.
Actual behavior
When running jgit a warning about an unknown commit-graph chunk is reported:
Expected behavior
No warning.
Relevant log output
No response
Other information
To reproduce checkout the branch https://github.com/khmarbaise/maven-it-extension/tree/git-commit-id-maven-plugin-issue-687 and run
mvn clean verify
.Can be reproduced using:
Can not be reproduced under linux and the same repository/branch/commit.
original bug-report: https://github.com/git-commit-id/git-commit-id-maven-plugin/issues/687