Closed pkriens closed 9 months ago
Thanks for this fix. Not sure how we ended up with this missing import.
We use Gerrit for code review, see https://github.com/eclipse-egit/egit/wiki/Contributor-Guide#contributing-patches
Hence I imported your PR to Gerrit for review here https://eclipse.gerrithub.io/c/eclipse-jgit/jgit/+/1173142
Not sure how we ended up with this missing import.
I know, you don't use bnd! :-) the idea of having to maintain the manifest by had can sometimes wake me up in sweat after a heavy meal ... 🤓
But kidding aside, the key problem is that Equinox allows you to get away with it ... they have bootloading on for javax which is basically a huge kick in the groin for OSGi. You pay the price for OSGi's complexity but you throw away the benefits of strong modularity.
Ah well, been having this discussion in the org since 2003 ...
ok, this explains why we didn't notice in Eclipse IDE
closing this PR since the change was submitted in Gerrit
Add an import for javax.net.ssl
See https://github.com/eclipse-jgit/jgit/issues/1 for details