eclipse-jgit / jgit

JGit, the Java implementation of git
https://www.eclipse.org/jgit/
Other
92 stars 31 forks source link

Don't use localized String during JVM shutdown #37

Closed TheSnoozer closed 4 months ago

TheSnoozer commented 4 months ago

During shutdown the JGitText class may already be unloaded causing NoClassDefFoundError.

See https://github.com/eclipse-jgit/jgit/issues/17 / https://github.com/eclipse-jgit/jgit/issues/36

msohn commented 4 months ago

We use Gerrit for code review, please push your change to git push https://eclipse.gerrithub.io/eclipse-jgit/jgit HEAD:refs/for/master See the contributor guide

TheSnoozer commented 4 months ago

Thanks for your insights.

During registration I was greeted with several server errors (500)...after I believe the 6th attempt I finally got an account on gerrithub, but I'm still unable to push any changes (remote: Contact an administrator to fix the permissions).

Since I technically still need to sign this eca and I fear this makes me waster another hour for a tiny change...I now give up to make this contribution.