search

eclipse-jkube / jkube

Build and Deploy java applications on Kubernetes
https://www.eclipse.dev/jkube/
Eclipse Public License 2.0
763 stars 504 forks source link

Support WebFlux SpringBoot projects when it comes to generate probes for actuators #1125

Closed nightswimmings closed 1 month ago

nightswimmings commented 2 years ago

SpringBootHealthCheckEnricher uses servlet properties exclusively in order to generate probes

prefix = springBootProperties.getProperty(propertyHelper.getServerContextPathPropertyKey(), "");
prefix += springBootProperties.getProperty(propertyHelper.getServletPathPropertyKey(), "");
prefix += springBootProperties.getProperty(propertyHelper.getManagementContextPathPropertyKey(), "");

When the service is reactive (webflux) the equivalent counterpart property is spring.webflux.base-path

rohanKanojia commented 2 years ago

Thanks for reporting this issue. Would it be possible for you to contribute a PR for this?

nightswimmings commented 2 years ago

I'll try to find a moment during this week, I guess it requires testing, because otherwise its a 10 min change

rohanKanojia commented 1 month ago

I see Spring Boot Configuration doc page and I only see spring.webflux.base-path having collisions with server.servlet.context-path.

There are other Webflux properties as well but they don't collide with existing properties used in SpringBootConfiguration