search

eclipse-jkube / jkube

Build and Deploy java applications on Kubernetes
https://www.eclipse.dev/jkube/
Eclipse Public License 2.0
775 stars 521 forks source link

GeneratorManager instantiation and access should be centralized in JKubeServiceHub #1731

Open manusa opened 2 years ago

manusa commented 2 years ago

Component

JKube Kit

Task description

JKubeServiceHub should be used as the central place to host, instantiate, and access services used by JKube components.

Currently, GeneratorManager is instantiated at the Mojo and Task level and then passed on to the services (Build & Resource) that require it.

Expected Behavior

Just like with BuildManager, the class should be accessed and instantiated from JKubeServiceHub.

bhanutejabt commented 2 years ago

Hi @manusa ,is this issue to be be resolved or not a priority?

If need to I can work on this if you assign.

BuildManager you meant by this file https://github.com/eclipse/jkube/blob/master/jkube-kit/config/service/src/main/java/org/eclipse/jkube/kit/config/service/BuildServiceManager.java.

manusa commented 2 years ago

This more of an internal refactor, needs proper analysis and action points. I don't think it's a good issue for external contributors :sweat:.

bhanutejabt commented 2 years ago

Yeah sure,Thanks for the confirmation.