Open ajeans opened 9 months ago
I'm not really sure that we should prescribe an icon. The linter is logging an info message with a suggestion.
We should check what other tools are doing (are they presrcribing an icon? what's the URL of the icon? and so on) and then make a decision about to provide a default value or not.
Hello @manusa
Yes that is debatable, this is indeed only an INFO message.
helm create foo
generates the following default chart
apiVersion: v2
name: foo
description: A Helm chart for Kubernetes
# A chart can be either an 'application' or a 'library' chart.
#
# Application charts are a collection of templates that can be packaged into versioned archives
# to be deployed.
#
# Library charts provide useful utilities or functions for the chart developer. They're included as
# a dependency of application charts to inject those utilities and functions into the rendering
# pipeline. Library charts do not define any templates and therefore cannot be deployed.
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.0
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "1.16.0"
No icon
there, so at least jkube would be consistent with it.
Component
Kubernetes Maven Plugin
Is your enhancement related to a problem? Please describe
k8s:helm
generates a helm file thathelm lint
complains about.1 chart(s) linted, 0 chart(s) failed
Describe the solution you'd like
Add a default value for
icon
.Maybe a link to the JKube icon?
Describe alternatives you've considered
No response
Additional context
No response