eclipse-jkube / jkube

Build and Deploy java applications on Kubernetes
https://www.eclipse.dev/jkube/
Eclipse Public License 2.0
760 stars 502 forks source link

The class CommandLine shouldn't implement Cloneable #2520

Closed manusa closed 9 months ago

manusa commented 9 months ago

Description

The class CommandLine implements the Cloneable interface despite being a simple utility class with a single static method.

The following line:

https://github.com/eclipse/jkube/blob/5da6068d7756784aef9569568ee80f98da97e296/jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/CommandLine.java#L23

Before you start :red_circle:

:point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down::point_down::point_down::point_down::point_down::point_down::point_down: Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

How to manually test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console. (Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)

l3002 commented 9 months ago

Hi @manusa, I would be glad to make a contribution through this issue. Kindly assign it to me.

rohan-2007 commented 9 months ago

I see this issue has been unassigned. if it is not yet solved, please assign it to me