eclipse-jkube / jkube

Build and Deploy java applications on Kubernetes
https://www.eclipse.dev/jkube/
Eclipse Public License 2.0
760 stars 502 forks source link

KubernetesSshServiceForwarder uses deprecated kubernetesClient.createOrReplace method #2524

Closed manusa closed 8 months ago

manusa commented 9 months ago

Description

The class KubernetesSshServiceForwarder uses the deprecated kubernetesClient.createOrReplace method.

The following line should be changed to (updating imports if necessary):

https://github.com/eclipse/jkube/blob/5da6068d7756784aef9569568ee80f98da97e296/jkube-kit/remote-dev/src/main/java/org/eclipse/jkube/kit/remotedev/KubernetesSshServiceForwarder.java#L113

Before you start :red_circle:

:point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down::point_down::point_down::point_down::point_down::point_down::point_down: Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

How to manually test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console. (Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)

sankritimishra commented 9 months ago

I want to work on this one, could you please assign this to me?

manusa commented 9 months ago

Hi @sankritimishra, this is a good-first-issue, the intention of these is to get new developers to acquaint with the project. You have already contributed to Eclipse JKube in the past. Please check the help-wanted issues to continue your journey.

suw0n commented 9 months ago

Hi, can i pick this up?

manusa commented 9 months ago

Hi, can i pick this up?

Sure @suw0n , I've assigned the issue to you, thx!