BuildConfigurationTest uses deprecated ObjectMapper.configure method

[manusa]

Description

The class BuildConfigurationTest uses a deprecated method.

The following lines should be changed to (updating imports if necessary):

https://github.com/eclipse/jkube/blob/275dc11e9bd0a268aac94f112ac2c443960d957b/jkube-kit/config/image/src/test/java/org/eclipse/jkube/kit/config/image/build/BuildConfigurationTest.java#L237-L238

• [x] should be changed to:

  final ObjectMapper mapper = JsonMapper.builder().configure(MapperFeature.USE_ANNOTATIONS, false).build();

Before you start :red_circle:

:point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down::point_down::point_down::point_down::point_down::point_down::point_down: Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

How to manually test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

• Minikube get started guide
• Kind (Requires Docker) quick start

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console. (Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)

[sankritimishra]

I'll be working on this

[anglerfishlyy]

can i work on this?

[rohanKanojia]

@anglerfishlyy : Are you still working on https://github.com/eclipse/jkube/pull/2879 ?

[anglerfishlyy]

No sir. I would like to go with first timers only issue.

[manusa]

Hi @anglerfishlyy, what's the status on this issue, have you progressed?

[anglerfishlyy]

actually , the lines are already changed to required one in the code. Is it still an issue that needs to be resolved?

[rohanKanojia]

@anglerfishlyy : Yes, you're right. Code still needs to be updated.

[manusa]

You're right, this was fixed in #2549

[manusa]

2528 wasn't fixed, so maybe you can attempt to fix that one. @anglerfishlyy, if you want, please comment in #2528 so that we can assign it to you.