search

eclipse-jkube / jkube

Build and Deploy java applications on Kubernetes
https://www.eclipse.dev/jkube/
Eclipse Public License 2.0
760 stars 502 forks source link

RegistryConfigTest uses deprecated ObjectMapper.configure method #2529

Closed manusa closed 9 months ago

manusa commented 9 months ago

Description

The class RegistryConfigTest uses a deprecated method.

The following lines should be changed to (updating imports if necessary):

https://github.com/eclipse/jkube/blob/5da6068d7756784aef9569568ee80f98da97e296/jkube-kit/common/src/test/java/org/eclipse/jkube/kit/common/RegistryConfigTest.java#L33-L34

Before you start :red_circle:

:point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down::point_down::point_down::point_down::point_down::point_down::point_down: Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

How to manually test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console. (Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)

Swaminathan11 commented 9 months ago

@manusa I have raised a pull request for this. Let me know if you need anything else. Happy to contribute. Thanks!

manusa commented 9 months ago

Hi, @Swaminathan11, thanks for your contribution. As a side note for future contributors, before starting your work on an issue, it's better if you comment the issue stating that you are going to work on it. This way we can assign it to you and then there will be less chances of several folks submitting the same fix in multiple PRs.