search

eclipse-jkube / jkube

Build and Deploy java applications on Kubernetes
https://www.eclipse.dev/jkube/
Eclipse Public License 2.0
733 stars 480 forks source link

OpenshiftBuildService Remove unused imports #3020

Open manusa opened 4 months ago

manusa commented 4 months ago

Description

The class OpenshiftBuildService has unused imports.

The following lines: https://github.com/eclipse-jkube/jkube/blob/e86c429ee70ef10b6ab08ae993861603f90a6789/jkube-kit/config/service/src/main/java/org/eclipse/jkube/kit/config/service/openshift/OpenshiftBuildService.java#L42

Before you start :red_circle:

:point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down::point_down::point_down::point_down::point_down::point_down::point_down: Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

How to manually test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console. (Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)

keerthinannepamula1 commented 3 months ago

@manusa Hey!! I'm new to the open source space. I managed to do around 3 PRs in my first week (this week). I'm searching java-based open source projects. May I work this issue? Atleast I'll try, I'll let you know if I can't.

vijaybhagwat24 commented 1 month ago

may I work on this?

rohanKanojia commented 1 month ago

@keerthinannepamula1 Are you still working on this?

rohanKanojia commented 1 month ago

@vijaybhagwat24 first-timers-only tagged issues are created for newcomers who are contributing to the project for the first time so that they can complete legal requirements and get familiar with project.

Now that you’ve completed that step, I would advise you to look into issues tagged with good first issue / help wanted labels . Or maybe create some new issue if you find something that should be fixed.