search

eclipse-jkube / jkube

Build and Deploy java applications on Kubernetes
https://www.eclipse.dev/jkube/
Eclipse Public License 2.0
712 stars 455 forks source link

SerializationTest : Replace AssertJ's deprecated `asList()` DSL method with `asInstanceOf(InstanceOfAssertFactories.list(type.class))` #3027

Closed rohanKanojia closed 1 month ago

rohanKanojia commented 1 month ago

Component

None

Task description

Description

In the latest versions of Assertj asList() DSL method has been marked as deprecated:

https://github.com/eclipse-jkube/jkube/blob/91be299e4b103ddf8db2029830dfa44176b62df2/jkube-kit/common/src/test/java/org/eclipse/jkube/kit/common/util/SerializationTest.java#L84-L85

users are advised to use asInstanceOf(InstanceOfAssertFactories.list(type.class)) instead, we need to update asList() calls with this. Once we use it, we can omit isInstanceOf(Pod.class) from line 85

Expected Behavior

AssertJ's asList() is replaced with asInstanceOf(InstanceOfAssertFactories.list(type.class))

Acceptance Criteria

jasonmokk commented 1 month ago

Hi @rohanKanojia I'd like to work on this as my first contribution. Could you please assign this to me?

rohanKanojia commented 1 month ago

@jasonmokk : Hello, help wanted issues are created for contributors who have already contributed to the project. I can see that you haven’t contributed to the project before.

Even if you are quite skilled, please consider doing one little (first-timers-only ) issue to get used to the process. After that, you are invited to move on up to the more difficult tasks, leaving some of the easy tasks to others so they can get involved and achieve change themselves.

Maybe you should start with issues created for first timers first-timers-only

jasonmokk commented 1 month ago

@rohanKanojia My apologies, thank you for informing me about the process. I will look into the first-timers-only issues

jasonmokk commented 1 month ago

Hello, may I have this issue assigned to me now?