search

eclipse-jkube / jkube

Build and Deploy java applications on Kubernetes
https://www.eclipse.dev/jkube/
Eclipse Public License 2.0
712 stars 455 forks source link

SpringBootGeneratorIntegrationTest : Replace AssertJ's deprecated `asList()` DSL method with `asInstanceOf(InstanceOfAssertFactories.list(type.class))` #3058

Closed rohanKanojia closed 1 month ago

rohanKanojia commented 1 month ago

Component

JKube Kit

Task description

Description

In the latest versions of Assertj asList() DSL method has been marked as deprecated: https://github.com/eclipse-jkube/jkube/blob/bfbf08d3e506b94f4e724e96e9ddcb230504b0ee/jkube-kit/jkube-kit-spring-boot/src/test/java/org/eclipse/jkube/springboot/generator/SpringBootGeneratorIntegrationTest.java#L219-L224 users are advised to use asInstanceOf(InstanceOfAssertFactories.list(type.class)) instead, we need to update asList() calls with this.

Expected Behavior

AssertJ's asList() is replaced with asInstanceOf(InstanceOfAssertFactories.list(type.class))

Acceptance Criteria

Josephvictor commented 1 month ago

Can I work on this?

rohanKanojia commented 1 month ago

@Josephvictor Hello, help wanted issues are created for contributors who have already contributed to the project. I can see that you haven’t contributed to the project before.

Even if you are quite skilled, please consider doing one little (first-timers-only ) issue to get used to the process. After that, you are invited to move on up to the more difficult tasks, leaving some of the easy tasks to others so they can get involved and achieve change themselves.

Maybe you should start with issues created for first timers first-timers-only

arman-yekkehkhani commented 1 month ago

@rohanKanojia Hello, could you assign it to me?