search

eclipse-jkube / jkube

Build and Deploy java applications on Kubernetes
https://www.eclipse.dev/jkube/
Eclipse Public License 2.0
712 stars 455 forks source link

DockerFileBuilder.CopyEntry Declaration can have final modifier #3103

Closed manusa closed 1 month ago

manusa commented 1 month ago

Description

The class DockerFileBuilder.CopyEntry has a field that can be declared final.

The following lines: https://github.com/eclipse-jkube/jkube/blob/5da6068d7756784aef9569568ee80f98da97e296/jkube-kit/config/image/src/main/java/org/eclipse/jkube/kit/config/image/build/DockerFileBuilder.java#L477

        private final String source;

Before you start :red_circle:

:point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down::point_down::point_down::point_down::point_down::point_down::point_down: Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

How to manually test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console. (Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)

bhiwagade-rahul commented 1 month ago

I want to work on the issue, can this be assigned to me?

rohanKanojia commented 1 month ago

@bhiwagade-rahul : first-timers-only tagged issues are created for newcomers who are contributing to the project for the first time so that they can complete legal requirements and get familiar with project.

Now that you’ve completed that step, I would advise you to look into issues tagged with good first issue / help wanted labels . Or maybe create some new issue if you find something that should be fixed.

Flowers2Algernon commented 1 month ago

@rohanKanojia Hi, I'm newcomers, can I do this? Please assign it to me. thank you