search

eclipse-jkube / jkube

Build and Deploy java applications on Kubernetes
https://www.eclipse.dev/jkube/
Eclipse Public License 2.0
747 stars 486 forks source link

DockerImageWatcherRestartContainerTest : Replace AssertJ's deprecated `asList()` DSL method with `asInstanceOf(InstanceOfAssertFactories.list(type.class))` #3176

Closed rohanKanojia closed 2 months ago

rohanKanojia commented 3 months ago

Component

JKube Kit

Task description

Description

In the latest versions of Assertj asList() DSL method has been marked as deprecated:

https://github.com/eclipse-jkube/jkube/blob/8b3ddfae846d2b8f485b97b8dc199227ded3fddc/jkube-kit/watcher/standard/src/test/java/org/eclipse/jkube/watcher/standard/DockerImageWatcherRestartContainerTest.java#L165

users are advised to use asInstanceOf(InstanceOfAssertFactories.list(type.class)) instead, we need to update asList() calls with this.

Expected Behavior

AssertJ's asList() is replaced with asInstanceOf(InstanceOfAssertFactories.list(type.class))

Acceptance Criteria

arman-yekkehkhani commented 3 months ago

@rohanKanojia Hi, May I work on this?