search

eclipse-jkube / jkube

Build and Deploy java applications on Kubernetes
https://www.eclipse.dev/jkube/
Eclipse Public License 2.0
724 stars 476 forks source link

BuildService 'nocache.length() == 0' can be replaced with 'nocache.isEmpty()' #3198

Open manusa opened 2 months ago

manusa commented 2 months ago

Description

The call to String.length can be replaced with isEmpty in BuildService.

The following line: https://github.com/eclipse-jkube/jkube/blob/9dee5b047481246be704a0408f71fc917fc0ac6c/jkube-kit/build/service/docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/BuildService.java#L219

should be changed to:

            return nocache.isEmpty() || Boolean.parseBoolean(nocache);

:red_circle: Before you start :red_circle:

:point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down:

Make sure you read the contributing guide first.

Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

This is a first-timers-only issue. These issues are especially created for contributors who are contributing to the project for the first time.

If you have already contributed to this project in the past, please don't ask to be assigned one of these issues and look for good-first-issues or help-wanted issues instead in order to continue you contributor journey in the project.

Aknummoalr commented 1 month ago

Hey @manusa can you please assign this issue to me.