eclipse-jkube / jkube

Build and Deploy java applications on Kubernetes
https://www.eclipse.dev/jkube/
Eclipse Public License 2.0
750 stars 487 forks source link

GoTimeUtil 'duration.length() == 0' can be replaced with 'duration.isEmpty()' #3202

Closed manusa closed 3 months ago

manusa commented 3 months ago

Description

The call to String.length can be replaced with isEmpty in GoTimeUtil.

The following line: https://github.com/eclipse-jkube/jkube/blob/5da6068d7756784aef9569568ee80f98da97e296/jkube-kit/enricher/api/src/main/java/org/eclipse/jkube/kit/enricher/api/util/GoTimeUtil.java#L60

should be changed to:

        if (duration.isEmpty()) {

:red_circle: Before you start :red_circle:

:point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down:

Make sure you read the contributing guide first.

Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

This is a first-timers-only issue. These issues are especially created for contributors who are contributing to the project for the first time.

If you have already contributed to this project in the past, please don't ask to be assigned one of these issues and look for good-first-issues or help-wanted issues instead in order to continue you contributor journey in the project.

SnehaHS65 commented 3 months ago

Hi manusa, can I take up this issue?

SamarthKoli commented 3 months ago

Hi, Manusa I am interested in contributing in this issue as this is my first Open source contribution

SnehaHS65 commented 3 months ago

I have raised the PR