eclipse-jkube / jkube

Build and Deploy java applications on Kubernetes
https://www.eclipse.dev/jkube/
Eclipse Public License 2.0
731 stars 479 forks source link

JKubeProjectUtil 'suffix.length() > 0' can be replaced with '!suffix.isEmpty()' #3231

Closed manusa closed 1 month ago

manusa commented 1 month ago

Description

The call to String.length can be replaced with isEmpty in JKubeProjectUtil.

The following line: https://github.com/eclipse-jkube/jkube/blob/a6215610db7080f2f9394565240086f0da80275e/jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/JKubeProjectUtil.java#L168

should be changed to:

        String ret = artifactId + (!suffix.isEmpty() ? "-" + suffix : "");

:red_circle: Before you start :red_circle:

:point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down:

Make sure you read the contributing guide first.

Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

This is a first-timers-only issue. These issues are especially created for contributors who are contributing to the project for the first time.

If you have already contributed to this project in the past, please don't ask to be assigned one of these issues and look for good-first-issues or help-wanted issues instead in order to continue you contributor journey in the project.

AhmedFaizanDev commented 1 month ago

Hi, this is my first time contributing to this project! Can this be assigned to me? :] Thank you!

eaknott commented 1 month ago

Hello, I have not yet contributed to this project, can I be assigned this issue? Thanks !~