search

eclipse-jkube / jkube

Build and Deploy java applications on Kubernetes
https://www.eclipse.dev/jkube/
Eclipse Public License 2.0
733 stars 480 forks source link

JibServiceUtilTest : Replace AssertJ's deprecated `asList()` DSL method with `asInstanceOf(InstanceOfAssertFactories.list(type.class))` #3242

Closed rohanKanojia closed 1 month ago

rohanKanojia commented 1 month ago

Component

None

Task description

Description

In the latest versions of Assertj asList() DSL method has been marked as deprecated:

https://github.com/eclipse-jkube/jkube/blob/b594cb13775dd64d13cbda48314c80f99082ef0f/jkube-kit/build/service/jib/src/test/java/org/eclipse/jkube/kit/service/jib/JibServiceUtilTest.java#L320

users are advised to use asInstanceOf(InstanceOfAssertFactories.list(type.class)) instead, we need to update asList() calls with this.

Expected Behavior

AssertJ's asList() is replaced with asInstanceOf(InstanceOfAssertFactories.list(type.class))

Acceptance Criteria

arman-yekkehkhani commented 1 month ago

@rohanKanojia Hi! Can I work on this issue?

vijaybhagwat24 commented 1 month ago

Hi @rohanKanojia, could you please assign this to me? thank you.