search

eclipse-jkube / jkube

Build and Deploy java applications on Kubernetes
https://www.eclipse.dev/jkube/
Eclipse Public License 2.0
774 stars 522 forks source link

DependencyEnricher: Unnecessary 'Arrays.asList()' call #3340

Closed manusa closed 2 months ago

manusa commented 2 months ago

Description

The class DependencyEnricher presents the issue: Unnecessary 'Arrays.asList()' call.

The following line: https://github.com/eclipse-jkube/jkube/blob/5da6068d7756784aef9569568ee80f98da97e296/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/DependencyEnricher.java#L136 should be changed to:

            HasMetadata[] templates = items.toArray(new HasMetadata[0]);

:red_circle: Before you start :red_circle:

:point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down:

Make sure you read the contributing guide first.

Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

This is a first-timers-only issue. These issues are especially created for contributors who are contributing to the project for the first time.

If you have already contributed to this project in the past, please don't ask to be assigned one of these issues and look for good-first-issues or help-wanted issues instead in order to continue you contributor journey in the project.

ChinoUkaegbu commented 2 months ago

Hi, could I be assigned to this?