search

eclipse-jkube / jkube

Build and Deploy java applications on Kubernetes
https://www.eclipse.dev/jkube/
Eclipse Public License 2.0
774 stars 521 forks source link

KubernetesWatchTaskTest: Statement lambda can be replaced with expression lambda #3372

Open manusa opened 2 months ago

manusa commented 2 months ago

Description

The class KubernetesWatchTaskTest presents the issue: Statement lambda can be replaced with expression lambda.

The following line: https://github.com/eclipse-jkube/jkube/blob/1868f35aafb872aae337b5b09d81878f2cce655a/gradle-plugin/kubernetes/src/test/java/org/eclipse/jkube/gradle/plugin/task/KubernetesWatchTaskTest.java#L62-L64 should be changed to:

    dockerBuildServiceMockedConstruction = mockConstruction(DockerBuildService.class, (mock, ctx) -> when(mock.isApplicable()).thenReturn(true));

:red_circle: Before you start :red_circle:

:point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down:

Make sure you read the contributing guide first.

Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

This is a first-timers-only issue. These issues are especially created for contributors who are contributing to the project for the first time.

If you have already contributed to this project in the past, please don't ask to be assigned one of these issues and look for good-first-issues or help-wanted issues instead in order to continue you contributor journey in the project.

bgayatri3 commented 2 months ago

Hi, could I get this issue

pujakarakoti07 commented 2 months ago

I want to contribute to this issue

manusa commented 2 months ago

Hi @pujakarakoti07 I just assigned #3368 to you

manusa commented 1 month ago

Hi, could I get this issue

Hi @bgayatri3

It's been 3 weeks since the issue was assigned, are you still working on it or I can assign to someone else?

bgayatri3 commented 1 month ago

Hi @manusa!

Apologies! I am still working on it, it will be done within the next week if that's ok.