search

eclipse-jkube / jkube

Build and Deploy java applications on Kubernetes
https://www.eclipse.dev/jkube/
Eclipse Public License 2.0
755 stars 496 forks source link

DaemonSetHandlerTest: Unused import 'import static org.mockito.Mockito.mock;' #3388

Closed manusa closed 2 days ago

manusa commented 2 weeks ago

Description

The class DaemonSetHandlerTest presents the issue: Unused import 'import static org.mockito.Mockito.mock;'.

The following line: https://github.com/eclipse-jkube/jkube/blob/487021f1a50fbf3a7269286e61dd119e2349c67c/jkube-kit/enricher/api/src/test/java/org/eclipse/jkube/kit/enricher/handler/DaemonSetHandlerTest.java#L38 should be removed.

:red_circle: Before you start :red_circle:

:point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down:

Make sure you read the contributing guide first.

Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

This is a first-timers-only issue. These issues are especially created for contributors who are contributing to the project for the first time.

If you have already contributed to this project in the past, please don't ask to be assigned one of these issues and look for good-first-issues or help-wanted issues instead in order to continue you contributor journey in the project.

gawadeatul commented 6 days ago

Hello @manusa , I am new to the Open Source contribution and really looking forward to contribute in this project. Can I work on this issue?

gawadeatul commented 4 days ago

Hello @rohanKanojia, PR (https://github.com/eclipse-jkube/jkube/pull/3418#issue) is ready, could you please review it and share your feedback.