search

eclipse-jkube / jkube

Build and Deploy java applications on Kubernetes
https://www.eclipse.dev/jkube/
Eclipse Public License 2.0
759 stars 502 forks source link

JibService: The declared exception is never thrown #3389

Open manusa opened 3 weeks ago

manusa commented 3 weeks ago

Description

The class JibService presents the issue: The declared exception is never thrown.

The following line: https://github.com/eclipse-jkube/jkube/blob/cd64fe79159d5070663c52a0541796e8b240dd43/jkube-kit/build/service/jib/src/main/java/org/eclipse/jkube/kit/service/jib/JibService.java#L78 should be changed to:

  public void close() {

:red_circle: Before you start :red_circle:

:point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down:

Make sure you read the contributing guide first.

Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

This is a first-timers-only issue. These issues are especially created for contributors who are contributing to the project for the first time.

If you have already contributed to this project in the past, please don't ask to be assigned one of these issues and look for good-first-issues or help-wanted issues instead in order to continue you contributor journey in the project.

AhmedFaizanDev commented 2 weeks ago

Can i work on this please?

rohanKanojia commented 2 weeks ago

@AhmedFaizanDev : first-timers-only](https://github.com/eclipse/jkube/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3Afirst-timers-only) tagged issues are created for newcomers who are contributing to the project for the first time so that they can complete legal requirements and get familiar with project.

Now that you’ve completed that step, I would advise you to look into issues tagged with good first issue / help wanted labels . Or maybe create some new issue if you find something that should be fixed.

Thulasithang commented 1 week ago

I would like to work on this issue @rohanKanojia

rohanKanojia commented 1 week ago

@Thulasithang first-timers-only tagged issues are created for newcomers who are contributing to the project for the first time so that they can complete legal requirements and get familiar with project.

Now that you’ve completed that step, I would advise you to look into issues tagged with good first issue / help wanted labels . Or maybe create some new issue if you find something that should be fixed.

ShlokNangia24 commented 1 week ago

Hey I would like to work on this issue if possible @rohanKanojia

ShlokNangia24 commented 2 hours ago

Created pull request