search

eclipse-jkube / jkube

Build and Deploy java applications on Kubernetes
https://www.eclipse.dev/jkube/
Eclipse Public License 2.0
773 stars 518 forks source link

ImageStreamServiceTest: Replace AssertJ's deprecated asList() DSL method with asInstanceOf(InstanceOfAssertFactories.list(type.class)) #3394

Closed ShivamChavan01 closed 1 month ago

ShivamChavan01 commented 1 month ago

Component

JKube Kit

Task description

In the latest versions of Assertj asList() DSL method has been marked as deprecated: The class ImageStreamServiceTest presents the issue: Usage of the deprecated method asList() from AssertJ.

The following lines of code: https://github.com/eclipse-jkube/jkube/blob/d2afc38505144ef4d5c1ff084d8e8ab83e9e5637/jkube-kit/config/service/src/test/java/org/eclipse/jkube/kit/config/service/openshift/ImageStreamServiceTest.java#L248

https://github.com/eclipse-jkube/jkube/blob/d2afc38505144ef4d5c1ff084d8e8ab83e9e5637/jkube-kit/config/service/src/test/java/org/eclipse/jkube/kit/config/service/openshift/ImageStreamServiceTest.java#L253

users are advised to use asInstanceOf(InstanceOfAssertFactories.list(type.class)) instead, we need to update asList() calls with this.

Expected Behavior

AssertJ'sasList()is replaced with asInstanceOf(InstanceOfAssertFactories.list(type.class))

Acceptance Criteria

ShivamChavan01 commented 1 month ago

@rohanKanojia i dont know how to add labels and please check as im right to issue this task or not

rohanKanojia commented 1 month ago

@ShivamChavan01 : Do you want to get this issue assigned to you?

ShivamChavan01 commented 1 month ago

@rohanKanojia yes & one more thing why is the issue number id is #3394 is it okay ??

SamarthKoli commented 1 month ago

i would like to work on this issue can you assign this to me

rohanKanojia commented 1 month ago

@SamarthKoli : This issue is already assigned to someone else. Could you please check for some other open issue?

rohanKanojia commented 1 month ago

yes & one more thing why is the issue number id is https://github.com/eclipse-jkube/jkube/issues/3394 is it okay ??

@ShivamChavan01 : Sorry, I don't understand your question. Could you please elaborate?