BuildService 'nocache.length() == 0' can be replaced with 'nocache.isEmpty()' #3198 Fix

Aknummoalr commented 1 month ago

Description

Fixes #3198

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] Feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change
[ ] Chore (non-breaking change which doesn't affect codebase; test, version modification, documentation, etc.)

Checklist

[x] I have read the contributing guidelines
[ ] I signed-off my commit with a user that has signed the Eclipse Contributor Agreement
[x] My code follows the style guidelines of this project
[x] I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
[ ] I use conventional commits in my commit messages
[x] I have performed a self-review of my code
[ ] I Added CHANGELOG entry
[ ] I have updated the documentation accordingly
[ ] No new bugs, code smells, etc. in SonarCloud report
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I tested my code in Kubernetes
[ ] I tested my code in OpenShift

manusa commented 1 month ago

Eclipse JKube CI Report

Started new GH workflow run for https://github.com/eclipse-jkube/jkube/pull/3434 (2024-10-10T05:45:28Z)

:gear: JKube E2E Tests (11268029872)

:heavy_check_mark: Bootstrap CI test run (#3434)
:x: K8S v1.25.13 dockerfile (#3434)
:x: K8S v1.25.13 other (#3434)
:x: K8S v1.25.13 quarkus (#3434)
:x: K8S v1.25.13 quarkus-native (#3434)
:x: K8S v1.25.13 springboot (#3434)
:x: K8S v1.25.13 webapp (#3434)
:x: K8S v1.28.1 dockerfile (#3434)
:x: K8S v1.28.1 other (#3434)
:x: K8S v1.28.1 quarkus (#3434)
:x: K8S v1.28.1 quarkus-native (#3434)
:x: K8S v1.28.1 springboot (#3434)
:x: K8S v1.28.1 webapp (#3434)
:heavy_check_mark: OpenShift v3.10.0 other (#3434)
:heavy_check_mark: OpenShift v3.10.0 quarkus (#3434)
:x: OpenShift v3.10.0 springboot (#3434)
:heavy_check_mark: OpenShift v3.10.0 webapp (#3434)
:heavy_check_mark: Windows (#3434)
:heavy_check_mark: Finish CI test run

Test results

:heavy_check_mark: Test reports (Windows)
``` [âœ“] WindowsITCase - k8sBuild - k8s:build, should create image [âœ“] WindowsITCase - k8sPush - k8s:push, should push image to remote registry [âœ“] WindowsITCase - k8sResource - k8s:resource, should create manifests [âœ“] WindowsITCase - ocResource - oc:resource, should create manifests [âœ“] WindowsITCase - k8sHelm - k8s:helm, should create Helm charts [âœ“] WindowsITCase - ocHelm - oc:helm, should create Helm charts [âœ“] All tests (6) passed successfully!!! ```

:heavy_check_mark: Test reports (OpenShift v3.10.0-quarkus)
``` [✓] QuarkusOcTraceEnabledITCase - ocBuild - oc:build, with org.slf4j.simpleLogger.defaultLogLevel=trace, should create image and print trace logs [✓] QuarkusOcTraceEnabledITCase - ocResource - oc:resource, should create manifests [✓] QuarkusOcITCase - ocBuild - oc:build, should create image [✓] QuarkusOcITCase - ocResource - oc:resource, should create manifests [✓] QuarkusOcTraceEnabledITCase - ocApply - oc:apply, with org.slf4j.simpleLogger.defaultLogLevel=trace, should deploy pod and service and print trace logs [✓] QuarkusOcITCase - ocHelm - oc:helm, should create Helm charts [✓] QuarkusOcTraceEnabledITCase - ocLog - oc:log, with org.slf4j.simpleLogger.defaultLogLevel=trace, should retrieve log and print trace logs [✓] QuarkusOcITCase - ocApply - oc:apply, should deploy pod and service [✓] QuarkusOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] QuarkusOcTraceEnabledITCase - ocUndeploy - oc:undeploy, with org.slf4j.simpleLogger.defaultLogLevel=trace, should delete all applied resources and print trace logs [✓] All tests (5) passed successfully!!! ```

:heavy_check_mark: Test reports (OpenShift v3.10.0-webapp)
``` [✓] WildFlyOcITCase - ocBuild - oc:build, should create image [✓] WildFlyOcITCase - ocResource - oc:resource, should create manifests [✓] WildFlyOcDockerModeITCase - ocBuild - oc:build, should create image using docker [✓] WildFlyOcDockerModeITCase - ocResource - k8s:resource, should create manifests [✓] JettyOcITCase - ocBuild - oc:build, should create image [✓] JettyOcITCase - ocResource - oc:resource, should create manifests [✓] ZeroConfigOcITCase - ocBuild - oc:build, should create image [✓] ZeroConfigOcITCase - ocResource - oc:resource, should create manifests [✓] WildFlyOcITCase - ocApply - oc:apply, should deploy pod and service [✓] WildFlyOcITCase - ocLog - oc:log, should retrieve logs [✓] WildFlyOcDockerModeITCase - ocApply - oc:apply, should deploy pod and service [✓] WildFlyOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] WildFlyOcDockerModeITCase - ocLog - oc:log, should retrieve logs [✓] JettyOcITCase - ocApply - oc:apply, should deploy pod and service [✓] WildFlyOcDockerModeITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] JettyOcITCase - ocLog - oc:log, should retrieve log [✓] ZeroConfigOcITCase - ocApply - oc:apply, should deploy pod and service [✓] ZeroConfigOcITCase - testNodePortResponse - Service as NodePort response should return String [✓] JettyOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] ZeroConfigOcITCase - ocLog - oc:log, should retrieve log [✓] ZeroConfigOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] All tests (5) passed successfully!!! ```

:x: Test reports (OpenShift v3.10.0-springboot)
``` [✓] HelmConfigOcITCase - ocResource - oc:resource, no specified profile, should create default resource manifests [✓] HelmConfigOcITCase - ocHelm - oc:helm, should create Helm charts [✓] HelmConfigOcITCase - ocHelmPush - oc:helm-push, should push the charts [X] HelmConfigOcITCase - ocHelmInstall - oc:helm-install, should install the charts [X] HelmConfigOcITCase - ocHelmUninstall - oc:helm-uninstall, should uninstall the charts [X] HelmConfigOcITCase - ocHelmUninstall_whenNoReleasePresent_thenErrorMessageDisplayed - oc:helm-uninstall, no release present, display error message [✓] ZeroConfigOcGradleITCase - ocBuild - ocBuild, should create image [✓] ZeroConfigOcGradleITCase - ocResource - ocResource, should create manifests [✓] CompleteOcDockerITCase - ocBuild - oc:build, with jkube.build.strategy=docker, should create image [✓] CompleteOcDockerITCase - ocResource - oc:resource, should create manifests [✓] ZeroConfigOcITCase - ocBuild - oc:build, should create image [✓] ZeroConfigOcITCase - ocResource - oc:resource, should create manifests [✓] WatchOcITCase - watch_whenSourceModified_shouldLiveReloadChanges - watch, SHOULD hot reload application on changes [✓] LayeredJarDisabledOcDockerITCase - ocBuild - oc:build, with jkube.build.strategy=docker, should create image [✓] ZeroConfigOcGradleITCase - ocApply - ocApply, should deploy pod and service [✓] LayeredJarDisabledOcDockerITCase - ocResource - oc:resource, should create manifests [✓] ZeroConfigOcGradleITCase - ocHelm - ocHelm, should create Helm charts [✓] ZeroConfigOcGradleITCase - ocLog - ocLog, should retrieve log [✓] ZeroConfigOcGradleITCase - ocUndeploy - ocUndeploy, should delete all applied resources [✓] CompleteOcDockerITCase - ocApply - oc:apply, should deploy pod and service [✓] CompleteOcDockerITCase - ocLog - oc:log, should retrieve log [✓] ZeroConfigOcITCase - ocApply - oc:apply, should deploy pod and service [✓] CompleteOcDockerITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] ZeroConfigOcITCase - ocHelm - oc:helm, should create Helm charts [✓] LayeredJarDisabledOcDockerITCase - ocApply - oc:apply, should deploy pod and service [✓] ZeroConfigOcITCase - ocLog - oc:log, should retrieve log [✓] LayeredJarDisabledOcDockerITCase - ocLog - oc:log, should retrieve log [✓] ZeroConfigOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] LayeredJarDisabledOcDockerITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] All tests (5) passed successfully!!! ```

:heavy_check_mark: Test reports (OpenShift v3.10.0-other)
``` [✓] ThorntailOcITCase - ocBuild - oc:build, should create image [✓] ThorntailOcITCase - ocResource - oc:resource, should create manifests [✓] OpenLibertyOcITCase - ocBuild - oc:build, should create image [✓] OpenLibertyOcITCase - ocResource - oc:resource, should create manifests [✓] WildflyJarOcITCase - ocBuild - oc:build, should create image [✓] WildflyJarOcITCase - ocResource - oc:resource, should create manifests [✓] DslOcGradleITCase - ocBuild - ocBuild, should create image [✓] DslOcGradleITCase - ocResource - ocResource, should create manifests [✓] VertxOcITCase - ocBuild - oc:build, should create image [✓] VertxOcITCase - ocResource - oc:resource, should create manifests [✓] KarafOcITCase - ocBuild - oc:build, should create image [✓] KarafOcITCase - ocResource - oc:resource, should create resource manifests [✓] ThorntailOcITCase - ocApply - oc:apply, should deploy pod and service [✓] ThorntailOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] OpenLibertyOcITCase - ocApply - oc:apply, should deploy pod and service [✓] OpenLibertyOcITCase - ocLog - oc:log, should retrieve log [✓] OpenLibertyOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] WildflyJarOcITCase - ocApply - oc:apply, should deploy pod and service [✓] WildflyJarOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] DslOcGradleITCase - ocApply - ocApply, should deploy pod and service [✓] DslOcGradleITCase - ocHelm - ocHelm, should create Helm charts [✓] DslOcGradleITCase - ocLog - ocLog, should retrieve log [✓] DslOcGradleITCase - ocUndeploy - ocUndeploy, should delete all applied resources [✓] VertxOcITCase - ocApply - oc:apply, should deploy pod and service [✓] VertxOcITCase - k8sLog - oc:log, should retrieve log [✓] VertxOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] KarafOcITCase - ocApply - oc:apply, should create pod, service and route [✓] KarafOcITCase - ocLog - oc:log, should retrieve log [✓] KarafOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] All tests (5) passed successfully!!! ```

rohanKanojia commented 1 month ago

@Aknummoalr Welcome, Thanks a lot for contributing to Eclipse JKube :+1:,

In order to contribute to Eclipse, you would need to create an Eclipse Account and Sign Eclipse Contributor Agreement. Once you've created an eclipse account you would need to update your commit message with a Signed-off-by: footer. You can do it like this:

# (Optional): Configure Git User and Email
git config user.name "Your Name"
git config user.email "your_email@example.com"

# Amend your previous commit with signed off footer
git commit --amend --signoff

# push changes again
git push origin yourbranchname -f

Aknummoalr commented 1 month ago

I removed the files requested by @rohanKanojia