search

eclipse-jkube / jkube

Build and Deploy java applications on Kubernetes
https://www.eclipse.dev/jkube/
Eclipse Public License 2.0
776 stars 523 forks source link

SimpleDockerfileUtilTest : Replace AssertJ's deprecated `asList()` DSL method with `asInstanceOf(InstanceOfAssertFactories.list(type.class))` #3441

Closed rohanKanojia closed 1 month ago

rohanKanojia commented 1 month ago

Component

JKube Kit

Task description

In the latest versions of Assertj asList() DSL method has been marked as deprecated:

https://github.com/eclipse-jkube/jkube/blob/e4af3d3ae2ab429c7c3af725e46482220902fc25/jkube-kit/generator/dockerfile-simple/src/test/java/org/eclipse/jkube/generator/dockerfile/simple/SimpleDockerfileUtilTest.java#L98

users are advised to use asInstanceOf(InstanceOfAssertFactories.list(type.class)) instead, we need to update asList() calls with this.

Expected Behavior

AssertJ's asList() is replaced with asInstanceOf(InstanceOfAssertFactories.list(type.class))

Acceptance Criteria

ShivamChavan01 commented 1 month ago

Hey @rohanKanojia ,

Can you please assign me this issue? I’m already working on it, and once assigned, I can create a pull request.

Thank you!