eclipse-jkube / jkube

Build and Deploy java applications on Kubernetes
https://www.eclipse.dev/jkube/
Eclipse Public License 2.0
775 stars 522 forks source link

`PodTemplateHandlerTest` : Issue: Replace Deprecated `asList()` with `asInstanceOf(InstanceOfAssertFactories.list(type.class))` #3464

Closed ShivamChavan01 closed 1 month ago

ShivamChavan01 commented 1 month ago

Component

JKube

Task description

Description

The PodTemplateHandlerTest class currently uses the deprecated AssertJ asList() method in the following lines:

https://github.com/eclipse-jkube/jkube/blob/1aeb58d8337beefa89b1e77c30e6a3d85633e152/jkube-kit/enricher/api/src/test/java/org/eclipse/jkube/kit/enricher/handler/PodTemplateHandlerTest.java#L89-L90 https://github.com/eclipse-jkube/jkube/blob/1aeb58d8337beefa89b1e77c30e6a3d85633e152/jkube-kit/enricher/api/src/test/java/org/eclipse/jkube/kit/enricher/handler/PodTemplateHandlerTest.java#L131

These occurrences need to be replaced with asInstanceOf(InstanceOfAssertFactories.list(...)) to comply with the latest AssertJ standards.

Expected Behavior

After replacing the asList() method with asInstanceOf(InstanceOfAssertFactories.list(...)), the unit tests should pass without any regression or failures.

Acceptance Criteria

ShivamChavan01 commented 1 month ago

assign me this @rohanKanojia