Open rohanKanojia opened 2 weeks ago
assign me @rohanKanojia
Hi @ShivamChavan01, Are you still working on it? if not, then @rohanKanojia can you please assign this to me
@saurabhmaurya1 I'm working on it sorry, I was AFK for a while but I'll will be working on this issue at eve
Component
JKube Kit
Task description
Related to https://github.com/eclipse/jkube/issues/2316
AbstractMicroprofileHealthCheckEnricherTest seems to be using mock here :
https://github.com/eclipse-jkube/jkube/blob/2221e72fe51862f1043895ac02235f3e28e33e7b/jkube-kit/jkube-kit-microprofile/src/test/java/org/eclipse/jkube/microprofile/enricher/AbstractMicroprofileHealthCheckEnricherTest.java#L68
This can easily be refactored to use real object using lombok builders:
Similarly these
when(
statements can also be replaced with builder calls like this:https://github.com/eclipse-jkube/jkube/blob/2221e72fe51862f1043895ac02235f3e28e33e7b/jkube-kit/jkube-kit-microprofile/src/test/java/org/eclipse/jkube/microprofile/enricher/AbstractMicroprofileHealthCheckEnricherTest.java#L172-L175
Usage of
org.mockito.Mockito.mock
andorg.mockito.Mockito.when
is removed from AbstractMicroprofileHealthCheckEnricherTestExpected Behavior
Usages of
Mockito.mock
andMockito.when
are removed from AbstractMicroprofileHealthCheckEnricherTestAcceptance Criteria