eclipse-kuksa / kuksa-actions

Reusable Github actions and workflows used in the Eclipse KUKSA project
Apache License 2.0
1 stars 2 forks source link

404 errors in check-markdown #10

Open erikbosch opened 3 months ago

erikbosch commented 3 months ago

As of today the check in https://github.com/eclipse-kuksa/kuksa-actions/tree/main/check-markdown accepts 404 errors. That is not optimal, but depends on that the framework the action use currently have problem parsing internal links correctly, so there are quite a lot of false positives

This issue is a reminder to revisit/retest the action to check if we later could remove the 404 limitation

How to test if we can update this action

erikbosch commented 3 months ago

A possible work-around could be to skip checks on internal links, see https://github.com/arduino/arduino-cli/pull/1692

erikbosch commented 3 months ago

Similar limitation for links including %, like https://github.com/eclipse-kuksa/kuksa-python-sdk/pkgs/container/kuksa-python-sdk%2Fkuksa-client

erikbosch commented 3 months ago

Current solution, skip links starting with # or containing %. Keep this open for a while to check if framework is fixed